feat: add support for newly supported svg filter in react-native-svg #969
+102
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
|
Author
|
Hello @gregberge , sorry to bother you but I wanted to bring out your attention for this pr if you have some free time |
|
Any news on this? It would be a great addition |
|
It is very strange that this is not merged till today, we had to do a patch to get our icons shadows (filter) to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding filter and is filter to be in the supported svg elements, they are now supported in the latest react-native-svg.
Here is the full list of supported elements.
An example for blur
Test plan
I added a test case for the above example, and ran it in a new expo app and it worked