Update webpack docs when using SVGR and asset SVG in the same project #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to use webpack 5's
resourceQuery
as defined in the previous docs, I kept getting a base64 string of the compiled react component not the svg.This ended up erroring out all usage of
import svg from 'my-svg.svg?url
since it wasn't actually a base64 of the xml svg. I updated the docs with the fix I used to only have the svgr loader called when the resourceQuery is not url.Also updated the
.gitignore
to ignore MacOS specific files in the future.Test plan
The
examples/webpack
didn't use theresourceQuery
option so the only edits were made to the documentation text. I ran the gatsby doc app locally to check that it works and reflected the change in the right spot and then linted/tested the entire repo.