Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to specify icon size #625

Merged
merged 2 commits into from
Nov 13, 2021
Merged

feat: allow to specify icon size #625

merged 2 commits into from
Nov 13, 2021

Conversation

gregberge
Copy link
Owner

BREAKING CHANGE: using --icon as latest arg now requires "--"

Fix #571

BREAKING CHANGE: using --icon as latest arg now requires "--"

Fix #571
@vercel
Copy link

vercel bot commented Nov 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/HuR3rh4UMVuv9sWgjQHQ6AMSnByG
✅ Preview: https://svgr-git-icon-size-gregberge.vercel.app

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #625 (483560d) into main (6ba16a3) will increase coverage by 0.10%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   89.12%   89.23%   +0.10%     
==========================================
  Files          32       32              
  Lines         699      715      +16     
  Branches      221      233      +12     
==========================================
+ Hits          623      638      +15     
- Misses         75       76       +1     
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/config.ts 100.00% <ø> (ø)
...ckages/babel-plugin-svg-em-dimensions/src/index.ts 89.28% <85.71%> (-5.46%) ⬇️
packages/babel-preset/src/index.ts 95.34% <100.00%> (+3.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba16a3...483560d. Read the comment docs.

@gregberge gregberge merged commit 1c5f163 into main Nov 13, 2021
@gregberge gregberge deleted the icon-size branch November 13, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native --icon should be 24 not 1em
1 participant