Replace SVGProps<SVGSVGElement> with ComponentProps<'svg'>
#1016
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfteuscher is attempting to deploy a commit to the Greg Berg's projects Team on Vercel. A member of the Team first needs to authorize it. |
mfteuscher
changed the title
SVGProps<SVGSVGElement> with ComponentProps<'svg'>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ComponentPropsgeneric type has become the standard for fetching native DOM types in TypeScript. This PR replaces the oldSVGProps<SVGSVGElement>prop with the newerComponentProps<'svg'>type. I personally find it much cleaner than the old way.Test plan
The new type
ComponentProps<'svg'>is backward compatible and equivalentSVGProps<SVGSVGElement>, so there should be no issue with an update. If downstream packages are running tests that use a pure text diff, this could potentially cause issues with a type change, but in terms of functionality, this will cause no breakage in the usage of an SVG