Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "createTime" instead of "createDate" #5

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

zorun
Copy link

@zorun zorun commented Apr 17, 2020

I was getting "Invalid date" as creation date in the interface, because
the Javascript didn't seem to like the format of the dates returned by
BBB.

Switch to using the "createTime" attribute which is a standard Unix
timestamp. It avoids the need to parse dates in Javascript.

Tested with BBB 2.2

I was getting "Invalid date" as creation date in the interface, because
the Javascript didn't seem to like the format of the dates returned by
BBB.

Switch to using the "createTime" attribute which is a standard Unix
timestamp.  It avoids the need to parse dates in Javascript.

Tested with BBB 2.2
@greenstatic
Copy link
Owner

Thanks for the PR, like I mentioned in #4, I'll confirm this works as expected on tomorrow / sunday at the latest and make a new release.

@zorun
Copy link
Author

zorun commented Apr 17, 2020

Ok, thanks!

Note that I changed an API field instead of adding a new field, breaking backwards compatibility of the API. But at this stage it doesn't look like a big issue, correct me if I'm wrong.

@greenstatic greenstatic merged commit 26f7013 into greenstatic:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants