You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ros build command now supports the --cmake-arg/-c option, enabling users to specify custom CMake arguments during the build process. Multiple arguments can be passed by repeating the option.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 63ddd2a2-361d-4732-80f0-0122141cad0b
📥 Commits
Reviewing files that changed from the base of the PR and between f4592d7 and cbb1b47.
📒 Files selected for processing (1)
platform_cli/groups/ros.py
Walkthrough
A new --cmake-arg/-c command-line option has been added to the ros build command in platform_cli/groups/ros.py. This option accepts multiple string values and allows users to pass additional CMake arguments to the underlying colcon build invocation. The provided CMake arguments are appended to the existing --cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS=ON segment within the generated build command string, positioned before any debug symbols configuration is applied.
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Title check
⚠️ Warning
The title lacks the required Shortcut task tracker link (e.g., SC-XXXX) and does not include a scope for the package, which are specified requirements.
Update the title to follow the format: 'feat: [SC-XXXX] (scope) add ability to specify extra cmake args' with the appropriate Shortcut task ID and package scope.
✅ Passed checks (3 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
Documentation
✅ Passed
The custom check for documentation updates applies specifically to changes to ROS nodes and requires updating design.md files. This pull request modifies platform_cli, a CLI tool, not a repository containing ROS nodes. The change adds a --cmake-arg/-c option to ros build, which is a CLI tool enhancement not modifying ROS node implementations, parameters, topics, or services.
Leaked Secrets
✅ Passed
The PR adds a --cmake-arg option for local builds only, with no mechanism to pass these arguments to Docker builds. Proper secret handling via Docker buildx secrets is already in place.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
ros buildcommand now supports the--cmake-arg/-coption, enabling users to specify custom CMake arguments during the build process. Multiple arguments can be passed by repeating the option.