Skip to content

feat: add ability to specify extra cmake args#16

Merged
TenzinPlatter merged 2 commits intomainfrom
specify-cmake-args
Apr 8, 2026
Merged

feat: add ability to specify extra cmake args#16
TenzinPlatter merged 2 commits intomainfrom
specify-cmake-args

Conversation

@TenzinPlatter
Copy link
Copy Markdown
Collaborator

@TenzinPlatter TenzinPlatter commented Apr 8, 2026

Summary by CodeRabbit

  • New Features
    • The ros build command now supports the --cmake-arg/-c option, enabling users to specify custom CMake arguments during the build process. Multiple arguments can be passed by repeating the option.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 63ddd2a2-361d-4732-80f0-0122141cad0b

📥 Commits

Reviewing files that changed from the base of the PR and between f4592d7 and cbb1b47.

📒 Files selected for processing (1)
  • platform_cli/groups/ros.py

Walkthrough

A new --cmake-arg/-c command-line option has been added to the ros build command in platform_cli/groups/ros.py. This option accepts multiple string values and allows users to pass additional CMake arguments to the underlying colcon build invocation. The provided CMake arguments are appended to the existing --cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS=ON segment within the generated build command string, positioned before any debug symbols configuration is applied.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title lacks the required Shortcut task tracker link (e.g., SC-XXXX) and does not include a scope for the package, which are specified requirements. Update the title to follow the format: 'feat: [SC-XXXX] (scope) add ability to specify extra cmake args' with the appropriate Shortcut task ID and package scope.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Documentation ✅ Passed The custom check for documentation updates applies specifically to changes to ROS nodes and requires updating design.md files. This pull request modifies platform_cli, a CLI tool, not a repository containing ROS nodes. The change adds a --cmake-arg/-c option to ros build, which is a CLI tool enhancement not modifying ROS node implementations, parameters, topics, or services.
Leaked Secrets ✅ Passed The PR adds a --cmake-arg option for local builds only, with no mechanism to pass these arguments to Docker builds. Proper secret handling via Docker buildx secrets is already in place.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@TenzinPlatter TenzinPlatter merged commit 39abe73 into main Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant