Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: work approval flow #109

Merged
merged 35 commits into from
Apr 3, 2025
Merged

feat: work approval flow #109

merged 35 commits into from
Apr 3, 2025

Conversation

Cygnusfear
Copy link

Signed-off-by: Alexander Mangel cygnusfear@gmail.com

Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
- exclode contracts/lib
- remove postcss/autoprefixer
- use tailwindcss/vite
- convert existing tv defs -> tailwind utilities
- convert existing typo -> typography.css
- appbar style conform figma
- remove customized tv export, remove customized cn export -> tailwind CSS classes now first class
- remove padding from root + add to appView

Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Custom based off radix/shadcn, lowlevel components with tv variants:

- accordion
- avatar
- badge
- card
- profile
- tabs

Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
green-goods ❌ Failed (Inspect) Mar 28, 2025 8:17am

Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
…tions

Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
@Oba-One Oba-One self-requested a review March 29, 2025 06:02
@Oba-One Oba-One self-assigned this Mar 29, 2025
@Oba-One Oba-One added this to the Interface for Approving Work milestone Mar 29, 2025
@Oba-One Oba-One added api Fetch some data and make it pretty component UI based component created in Storybook state-logic It's all about business logic labels Mar 29, 2025
Copy link
Member

@Oba-One Oba-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Work card still need polish
  • Work view need some polish on text overflow for title and better formatting of media in carousel
  • Work view still need polish upon successful approval or rejection of work
  • Assessment view is blank and need to show the full assessment
  • Loader needed for assessment tab view as well
  • Greenway garden work tab view stays in endless loading mode
  • Need placeholder image for work with no media

@github-project-automation github-project-automation bot moved this from Backlog to In progress in Green Goods Mar 29, 2025
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
Signed-off-by: Alexander Mangel <cygnusfear@gmail.com>
@github-project-automation github-project-automation bot moved this from In progress to Done in Green Goods Apr 3, 2025
@Oba-One Oba-One merged commit c9eb688 into main Apr 3, 2025
4 checks passed
Oba-One added a commit that referenced this pull request Apr 3, 2025
Oba-One added a commit that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Fetch some data and make it pretty component UI based component created in Storybook state-logic It's all about business logic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Operator Work Approval State Management Operator Work Approval Components Gardener Work View Components
2 participants