Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Remove unused exclusions from plugins. Adjust one test. #720

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Jun 27, 2024

What

Parity PR for greenbone/vulnerability-tests#11742

Note: No new release required, can be shipped with one of the next ones.

Why

The exclusions are now just not required anymore as the nmap NSE scripts are deprecated since many years and the (too long) summary tag has been dropped (in greenbone/vulnerability-tests#11732) which made the exclusions now superfluous.

References

N/A

Checklist

  • Tests

@cfi-gb cfi-gb requested a review from a team as a code owner June 27, 2024 07:00
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (642e21f) to head (f7d42f8).
Report is 2 commits behind head on main.

Current head f7d42f8 differs from pull request most recent head 42c9c40

Please upload reports for the commit 42c9c40 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files          85       85           
  Lines        2823     2823           
  Branches      596      596           
=======================================
  Hits         2243     2243           
  Misses        440      440           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbrinkhoff mbrinkhoff added the make release To trigger GitHub release action label Jun 27, 2024
@mbrinkhoff mbrinkhoff enabled auto-merge (rebase) June 27, 2024 22:11
@mbrinkhoff mbrinkhoff merged commit a5aaf12 into main Jun 27, 2024
10 checks passed
@mbrinkhoff mbrinkhoff deleted the drop_exclusions branch June 27, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants