Fix: typing of version-modules #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tacire
commented
Jan 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 70 70
Lines 4751 4751
Branches 634 634
=======================================
Hits 4176 4176
Misses 412 412
Partials 163 163
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjoernricks
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed typing errors
Tested using
poetry run mypy pontos/versionWhy
To prepare pontos for possible automated type-checkes in the future
Checklist