Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add target option for setting dedicated port list for alive detection #323

Merged
merged 4 commits into from
Aug 27, 2020

Conversation

ArnoStiefvater
Copy link
Member

@ArnoStiefvater ArnoStiefvater commented Aug 26, 2020

What:

Add target option for setting dedicated port list for alive detection .

Depends on:
greenbone/ospd-openvas#327
greenbone/gvm-libs#391

Why:

It enhances the flexibility when doing alive scans.

How:

Used gvm-cli for scans. Added <alive_test_ports>22,80<alive_test_ports> and checked with a print if these ports were actually used during a scan. Checked if defaults were used if no alive_test_ports was provided.

Checklist:

Dedicated port list can be provided for alive
detection. This port list can be taken by Boreas
for TCP-SYN and TCP-ACK scans.
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #323 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   73.54%   73.52%   -0.02%     
==========================================
  Files          23       23              
  Lines        2529     2531       +2     
==========================================
+ Hits         1860     1861       +1     
- Misses        669      670       +1     
Impacted Files Coverage Δ
ospd/protocol.py 87.23% <50.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfcd44b...8917857. Read the comment docs.

@ArnoStiefvater ArnoStiefvater marked this pull request as ready for review August 27, 2020 10:01
@jjnicola jjnicola merged commit a903784 into greenbone:master Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants