Ospd-openvas is able to run a scan. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions related to the NVT information.
Import modules. Use 0 and 1 instead of 'no' and yes' for boolean in parameters.
Also improve code style.
Add some default scan results.
wiegandm
suggested changes
Jun 28, 2018
ospd_openvas/nvticache.py
Outdated
| xml_timeout.text = timeout | ||
| preferences.append(xml_timeout) | ||
|
|
||
| if len(resp) > 0: |
There was a problem hiding this comment.
You could make use of the fact that empty sequences are false and simplify this to if resp: if you think it would improve readability, see https://www.python.org/dev/peps/pep-0008/#programming-recommendations
ospd_openvas/nvticache.py
Outdated
| resp = ctx.lrange("nvt:%s" % oid, | ||
| openvas_db.nvt_meta_fields.index("NVT_FILENAME_POS"), | ||
| openvas_db.nvt_meta_fields.index("NVT_VERSION_POS")) | ||
| if (isinstance(resp, list) and len(resp) > 0) is False: |
There was a problem hiding this comment.
See above, len(resp) > 0 could be simplified to resp if so desired -- or even reduce it to: if not isinstance(resp, list): since isinstance(False, list) is False.
ospd_openvas/wrapper.py
Outdated
| """ Create a string representation of the XML object from the | ||
| custom data object. | ||
|
|
||
| The custom XML object which is returned will be embedded |
There was a problem hiding this comment.
Does the function actually do what its docstring describes? As far as I can tell it merely returns its parameter custom as-is.
Also, consider declaring this method a static method as it does not look like it modifies the instance.
Make method static and fix docstring.
wiegandm
approved these changes
Jun 29, 2018
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Drop ChangeLog file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the kb to run a scan.
Retrieve results from Redis.
When the scan finished, clean the redis kb.
If the scan is stopped with <stop_scan scan_id=...>, stop the scan cleanly and delete the redis kb.
Add custom NVTs metadata to the <get_vts/> response.