Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set required version of psutil in setup.py #493

Closed
wants to merge 1 commit into from
Closed

Set required version of psutil in setup.py #493

wants to merge 1 commit into from

Conversation

simonflood
Copy link

What:

Set requirement for Python psutil module to be >=5.7.2,<6.0.0 in setup.py.

Why:

Following the docs to build GVM 21.04 on Ubuntu 20.04, installing ospd-openvas reports this requirement as an error.

How:

On Ubuntu 20.04 I manually made this change via sed, then re-ran the relevant "python3 -m pip install" command.

Installing ospd-openvas reports that ospd has requirement of psutil to be 5.7.2 or greater, but less than 6.0.0.
@simonflood simonflood requested a review from a team as a code owner August 19, 2021 14:46
@bjoernricks
Copy link
Contributor

Hi thanks for contributing. This issue has already been addressed in #490 and will be fixed with the next release. Actually we require a lower version of psutil and have adjusted our the setup file to use a version >= 5.5.1 which is the version shipped in debian buster.

@simonflood
Copy link
Author

Thanks for downgrading psutil. However manually making the change to the pyproject.toml file for 21.04 (as per #490) before running the python3 -m pip ... command to install ospd-openvas still includes "ERROR: ospd 21.4.3 has requirement psutil<6.0.0,>=5.7.2, but you'll have psutil 5.5.1 which is incompatible." in the output as I previously reported here.

@y0urself
Copy link
Member

maybe thats because we use the pyproject.toml and not `setup.py. You should go and change it there, like in the PR #490 you mentioned?

@simonflood
Copy link
Author

Even with 'psutil==5.5.1' in the setup.py files for both ospd and ospd-openvas I'm still seeing "ERROR: ospd 21.4.3 has requirement psutil<6.0.0,>=5.7.2, but you'll have psutil 5.5.1 which is incompatible." when I install ospd-openvas.

This is on a fresh install of Ubuntu Server 20.04 LTS which has python3-psutil version 5.5.1.

@y0urself
Copy link
Member

y0urself commented Aug 27, 2021

Did you even read my comment? I am talking about the pyproject.toml file. That is used for installing, not the setup.py. You need to change it there, as in the PR.

https://pip.pypa.io/en/stable/cli/pip/#build-system-interface

pip builds packages by invoking the build system. By default, builds will use setuptools, but if a project specifies a different build system using a pyproject.toml file, as per PEP 517, pip will use that instead.

@simonflood
Copy link
Author

As I said in my earlier comment #493 (comment) "manually making the change to the pyproject.toml file ... still includes ERROR". Following your subsequent comment I then also tried setup.py as well as pyproject.toml (and poetry.lock for good measure) but I'm still seeing the error. I can't see where else in ospd-openvas the requirement for ospd to be <6.0.0,>=5.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants