Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Circleci and Coverage conf file. #44

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Dec 18, 2018

No description provided.

@jjnicola jjnicola requested review from bjoernricks and removed request for bjoernricks December 18, 2018 14:35
@jjnicola jjnicola force-pushed the circleci branch 3 times, most recently from ddabd6f to 12093be Compare December 18, 2018 15:08
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
ospd_openvas/db.py Outdated Show resolved Hide resolved
tests/testWrapper.py Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@jjnicola jjnicola removed the request for review from bjoernricks December 19, 2018 12:57
@jjnicola jjnicola requested a review from davidak December 19, 2018 13:08
@jjnicola jjnicola changed the title Add unit test, add Circleci and Coverage conf file. Add Circleci and Coverage conf file. Dec 19, 2018
@jjnicola jjnicola force-pushed the circleci branch 4 times, most recently from 4c5bfcd to a892eeb Compare December 19, 2018 14:02
@jjnicola jjnicola removed the request for review from davidak December 19, 2018 14:02
@jjnicola jjnicola force-pushed the circleci branch 2 times, most recently from 62b441d to 9af450c Compare December 19, 2018 14:10
@jjnicola jjnicola requested a review from davidak December 19, 2018 14:13
Copy link
Contributor

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the lines i commented.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@jjnicola
Copy link
Member Author

I splitted out the original PR in two. Another one is coming with the unit tests.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bjoernricks bjoernricks dismissed davidak’s stale review December 20, 2018 12:33

All changes have been addressed

@bjoernricks bjoernricks merged commit d352146 into greenbone:master Dec 20, 2018
@jjnicola jjnicola deleted the circleci branch March 18, 2019 11:10
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Add functions for port manipulation and its unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants