Improve vt element regarding dates, empty elements and tags #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tag element, as it is get it from redis, has inside multiple tags separated by a "|" symbol. Now it is splitted and each single tag is an entry in the vts dictionary.
Before, these tags were parts the of "custom" members. Now they are explicits members of each vt, in the same level as custom.
Return the modification time and creation time as it is, since the text does not need to be processed.
Use the tags stored in the vts dictionary under the custom member instead of getting the data from redis.
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Start with param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each tag inside custom is an independent element.
Move creation_time and modification_time inside the vts dictionary.
Do not add empty elements into the vts dictionary.
As the vts dictionary changed and tags are independent elements, takes result's qod and severity from the dict. This avoid a redis query for each result.