Add definition for NVTICACHE_STR. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
nvticache-str-version
branch
from
c1a9f0a to
95cdbff
Compare
jjnicola
changed the title
jjnicola
changed the title
kroosec
reviewed
Sep 26, 2018
src/pluginscheduler.c
Outdated
| @@ -139,6 +139,16 @@ plugin_add (plugins_scheduler_t sched, GHashTable *oids_table, | |||
| } | |||
|
|
|||
| category = nvti_category (nvti); | |||
| if (category < 0) | |||
There was a problem hiding this comment.
Both PRs are good, except this part. IMO, it is better to use an assert(category >= 0) and in the case of an old/corrupted cache, this message would be printed for the thousands of plugins that are loaded.
jjnicola
force-pushed
the
nvticache-str-version
branch
2 times, most recently
from
4a00cbf to
fe41518
Compare
Use the gvm-libs release version in the name of the nvticache. This avoid to use an old nvticache structure stored in redis if a new gvm-libs version is installed, cleaning the old one and loading up the NVTs acording to the new structure.
jjnicola
force-pushed
the
nvticache-str-version
branch
2 times, most recently
from
f8d3fac to
47e78cc
Compare
kroosec
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on greenbone/gvm-libs#124
Assert if a plugin doesn't have a valid category.
Use the gvm-libs release version in the name of the nvticache.
This avoid to use an old nvticache structure stored in redis if a
new gvm-libs version is installed, cleaning the old one and loading up
the NVTs acording to the new structure.