Skip to content

Conversation

@badarghal
Copy link
Contributor

What

It adds a new safer and easier to use implementation of dbcrypt package.

Why

Old implementation was riddled with bugs, security issues, it was hard to use and it was extremely easy to make mistakes and brake the system.

References

Checklist

  • Tests

@greenbonebot
Copy link
Member

Scanning the following files:

pkg/dbcrypt/cipher.go
pkg/dbcrypt/crypto.go
pkg/dbcrypt/dbcryptv2.go
pkg/dbcrypt/dbcryptv2_test.go
pkg/dbcrypt/value.go

Scan: 'pkg/dbcrypt/cipher.go'

Nothing detected in pkg/dbcrypt/cipher.go
Scan took 0.00 seconds

Scan: 'pkg/dbcrypt/crypto.go'

Nothing detected in pkg/dbcrypt/crypto.go
Scan took 0.00 seconds

Scan: 'pkg/dbcrypt/dbcryptv2.go'

Nothing detected in pkg/dbcrypt/dbcryptv2.go
Scan took 0.00 seconds

Scan: 'pkg/dbcrypt/dbcryptv2_test.go'

Nothing detected in pkg/dbcrypt/dbcryptv2_test.go
Scan took 0.00 seconds

Scan: 'pkg/dbcrypt/value.go'

Nothing detected in pkg/dbcrypt/value.go
Scan took 0.00 seconds

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Conventional Commits Report

Type Number
Changed 4

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 61.82573% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.19%. Comparing base (510e32d) to head (9773f7b).

Files with missing lines Patch % Lines
pkg/dbcrypt/crypto.go 57.62% 30 Missing and 20 partials ⚠️
pkg/dbcrypt/cipher.go 58.82% 14 Missing and 14 partials ⚠️
pkg/dbcrypt/dbcipher.go 74.54% 8 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   55.90%   56.19%   +0.28%     
==========================================
  Files          61       62       +1     
  Lines        3225     3390     +165     
==========================================
+ Hits         1803     1905     +102     
- Misses       1293     1328      +35     
- Partials      129      157      +28     
Flag Coverage Δ
opensearch-tests 95.66% <ø> (ø)
postgres-tests 91.96% <ø> (ø)
unit-tests 49.63% <61.82%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants