add: notifications - add current timestamp if not set by caller #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catching up on previously missed adjustemnts
Timestamp set by caller is more precise, but for convenience set it in the notification client if it is unset. This prevents accidentally setting zero time and is more robust compared to returning an error in this case.
Conventional Commits Report
🚀 Conventional commits found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
notifications - add current timestamp if not set by caller
Why
Timestamp set by caller is more precise, but for convenience set it in the notification client if it is unset. This prevents accidentally setting zero time and is more robust compared to returning an error in this case.
Checklist