Allow resuming OSPd-based OpenVAS tasks (9.0) #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new scanner type previously always started a new scan and report. This commit will currently just clear the existing report and reuse it. Scanning only unfinished hosts again or recovering scans from a still running scanner will be handled later.
If the OSP scanner is still running or finished gvmd can still get the results without starting a new scan.
When resuming a task where the task was stopped start the OSP scan only for the unfinished hosts instead of rescanning everything.
The new version of the gvm-libs is required to be able to use the new element `finished_hosts` in the `start_scan` OSP command.
While it's possible to simply continue getting the results from the scanner if it's finished or still runnig, gvmd may have crashed while receiving or storing the results, so some may be missing.
mattmundell
requested changes
Nov 18, 2019
This file was created and added accidentally.
mattmundell
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new scanner type previously always started a new scan and report.
With this PR the last stopped or interrupted report is reused and only unfinished hosts are rescanned, as it was done before switching to OSP.
Checklist: