Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config preferences after updating NVTs (9.0) #832

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Update config preferences after updating NVTs (9.0) #832

merged 5 commits into from
Oct 25, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 25, 2019 •
edited
Loading

This ensures the configs still apply if preference names are changed in
the NVTs.

Checklist:

@timopollmeier
Update config preferences after updating NVTs
cf3a338 
This ensures the configs still apply if preference names are changed in
the NVTs.
@timopollmeier timopollmeier changed the title Update config preferences after updating NVTs Update config preferences after updating NVTs (9.0) Oct 25, 2019
@timopollmeier timopollmeier marked this pull request as ready for review October 25, 2019 10:17
mattmundell
mattmundell requested changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

src/manage_sql_nvts.c Outdated Show resolved Hide resolved
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
timopollmeier and others added 2 commits October 25, 2019 14:48
@timopollmeier @mattmundell
Fix spaces in check_preference_names SQL
1339d66 
Co-Authored-By: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
@timopollmeier
Fix comment about preference name updates
991b9d1
@mattmundell mattmundell merged commit 6c336a7 into greenbone:gvmd-9.0 Oct 25, 2019
@timopollmeier timopollmeier deleted the update-configs-from-nvts-9.0 branch June 9, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmundell mattmundell mattmundell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timopollmeier @mattmundell