Get refs in the NVT SQL when updating nvti_cache #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is about a 10s improvement on gvmd startup time. Previously we ran a separate SQL statement for each NVT, to retrieve the refs.
timopollmeier
requested changes
Oct 24, 2019
timopollmeier
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the gvmd startup time by about 10s. Previously we ran a separate SQL statement for each NVT, to retrieve the refs.
Slow gvmd startup time really frustrates me during development.
I printed and diffed nvti_cache to confirm that it was the same before and after the patch.
Checklist: