Eliminate get_tag() and parse_tags(). #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function get_tag() only parses the cvss_base_vector from the incoming OSP XML for a VT and adds it to the nvti tags string. Using the new function nvt_add_tag() makes avoids the knowledge about the internal syntax (pipe-separated list). This last tag that is parsed is now located in function nvti_from_vt(). Also this removes the parsing for "cvss_base" inside the tags string which happened in nvti_from_vt(). Actually it is not being parsed anyway but rather computed from the vector.
This finally removes the parse_tags() function that was aware of the pipe-separated internal syntax of tags.
janowagner
changed the title
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
mattmundell
requested changes
Sep 11, 2019
mattmundell
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function get_tag() only parses the cvss_base_vector
from the incoming OSP XML for a VT and adds it to the nvti tags
string.
Using the new function nvt_add_tag() makes avoids the knowledge
about the internal syntax (pipe-separated list).
This last tag that is parsed is now located in function nvti_from_vt().
Also this removes the parsing for "cvss_base" inside the tags
string which happened in nvti_from_vt(). Actually it is not being
parsed anyway but rather computed from the vector.
This is done now directly after parsing the cvss_base_vector from
XML inside nvt_from_vt().
An in turn this make it possible to remove parse_tags() function,
another place where the internal knowledge about the pipe-separated
syntax for tags was present.
This requires greenbone/gvm-libs#263
Checklist: