Drop bid and xref from table nvts #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
drop_bid_and_xref_from_table_nvts
branch
from
6529f41
to
22c20da
Compare
mattmundell
approved these changes
Jun 10, 2019
mattmundell
requested changes
Jun 10, 2019
mattmundell
approved these changes
Jun 12, 2019
janowagner
force-pushed
the
drop_bid_and_xref_from_table_nvts
branch
from
2c08ea0
to
2911e65
Compare
This removes the fields "bid" and "xref" from table "nvts". Basically the table is dropped. It will be rebuild automatically during next feed update.
vt_oid is not used.
janowagner
force-pushed
the
drop_bid_and_xref_from_table_nvts
branch
from
2911e65
to
9fa1137
Compare
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 92.6% 93.08% +0.48%
==========================================
Files 63 58 -5
Lines 5384 5353 -31
==========================================
- Hits 4986 4983 -3
+ Misses 398 370 -28
Continue to review full report at Codecov.
|
mattmundell
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the items "bid" and "xref" from table "nvts".