Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When hash or password are NULL return INVALID rather then ERR #496

Merged
merged 1 commit into from
May 10, 2021
Merged

When hash or password are NULL return INVALID rather then ERR #496

merged 1 commit into from
May 10, 2021

Conversation

nichtsfrei
Copy link
Member

To make it easier to handle hash or passqord unset cases for the caller
gvm-libs passwordbasedauthentication should not threat hash or password
is a nullpointer as an error case but rather as a invalid password.

What:

Why:

How:

Checklist:

@nichtsfrei nichtsfrei requested a review from a team as a code owner May 10, 2021 13:12
@nichtsfrei nichtsfrei added backport-to-stable This pull request will be backported to the 21.04 branch backport-to-main This pull request will be ported to the master branch labels May 10, 2021
@nichtsfrei nichtsfrei marked this pull request as draft May 10, 2021 13:27
@nichtsfrei nichtsfrei marked this pull request as ready for review May 10, 2021 13:38
To make it easier to handle hash or passqord unset cases for the caller
gvm-libs passwordbasedauthentication should not threat hash or password
is a nullpointer as an error case but rather as a invalid password.
@nichtsfrei nichtsfrei merged commit c16719c into greenbone:gvm-libs-20.08 May 10, 2021
nichtsfrei added a commit that referenced this pull request May 10, 2021
When hash or password are NULL return INVALID rather then ERR (backport #496)
nichtsfrei added a commit that referenced this pull request May 10, 2021
When hash or password are NULL return INVALID rather then ERR (backport #496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch backport-to-stable This pull request will be backported to the 21.04 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants