Fix static code analysis warnings #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent possibility of use after free.
mattmundell
requested changes
Jan 26, 2021
base/networking.c
Outdated
| @@ -782,9 +782,9 @@ ip_islocalhost (struct sockaddr_storage *storage) | |||
| struct in_addr addr; | |||
| struct in_addr *addr_p; | |||
| struct in6_addr addr6; | |||
| struct in6_addr *addr6_p; | |||
| struct in6_addr *addr6_p = NULL; | |||
There was a problem hiding this comment.
These look wrong, because they're set directly below. Wouldn't recommend adding them just to quiet clang, but if you want to I recommend adding a note that it's for clang.
base/logging.c
Outdated
| @@ -510,7 +510,7 @@ gvm_log_func (const char *log_domain, GLogLevelFlags log_level, | |||
| /* Make the tmp pointer (for iteration) point to the format string. */ | |||
| tmp = prepend_format; | |||
|
|
|||
| while (*tmp != '\0') | |||
There was a problem hiding this comment.
I guess there should rather be a NULL check at line 483 like there is at line 441, to prevent prepend_format from ever being NULL.
There was a problem hiding this comment.
I don't think it's good to let tmp be NULL because then prepend_buf ends up "" instead of the default "%t %s %p - ".
Remove possibility of having garbage value in call to IN6_ARE_ADDR_EQUAL
gnutls_certificate_set_dh_params only stores a pointer to the parameters in the certificate handle, so you must not deallocate the parameters before the certificate is deallocated.
ArnoStiefvater
force-pushed
the
fix-compiler-warnings
branch
from
77d8697
to
1533c00
Compare
mattmundell
approved these changes
Jan 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix warnings of static code analysis.
Why:
Improve code quality and make CI happy.
How:
Install
clang-tools-7and run static code analysis with e.g.:mkdir build && cd build/ && /bin/scan-build-7 cmake -DCMAKE_BUILD_TYPE=Debug .. && /bin/scan-build-7 -o tmp/scan-build-report make && [ -z "$(ls -A tmp/scan-build-report/)" ]Checklist: