Improve ARP ping #423
Merged
Improve ARP ping #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call pingip_send() not always with the same libnet_t which means that ptags should not be static.
ArnoStiefvater
force-pushed
the
improve-arp
branch
from
d3c1d7a
to
e0f4f26
Compare
We can reuse the libnet context if the interface for a given packet is the same as the privously used one. We do not need to resolve the address here because it is done somewhere else and saved in the gvm_host_t. If we already have a src address we do not need to find one.
Else we send the last packet as payload for the new one. Better would be to use ptags for reuse and modification of packets.
ArnoStiefvater
force-pushed
the
improve-arp
branch
from
80a6bd8
to
856f478
Compare
mattmundell
previously approved these changes
Jan 26, 2021
send_arp_v4 only takes IPv4 in text form and not IPv6 mapped IPv4 string in text form.
ArnoStiefvater
force-pushed
the
improve-arp
branch
from
68e33ec
to
9ef35c5
Compare
Use always the same default interface found by pcap_findalldevs if we have not found one on our own as the default interface should not change during different pings. Use pcap_findalldevs instead of pcap_lookupdev.
Reduce number of debug messages by unifying messages with same meaning.
jjnicola
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use libnet for arp ping for alive detection.
Why:
Robust implementation of arp ping as it was not stable before. The arp ping is part of the experimental (currently default off) alive detection feature.
How:
Can be tested with cli front-end for the alive test https://github.com/greenbone/boreas/ and do some scans with it.
sudo boreas --target "0:0:0:0:0:ffff:c0a8:384b,192.168.42.42" --arpChecklist: