Retry if response via tls1.3 is still not received. #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
approved these changes
Aug 31, 2020
This was referenced Oct 1, 2020
[20.8.0] Service unavailable when verifying ospd-openvas scanner over tcp
greenbone/ospd-openvas#341
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Retry if xml response via tls1.3 is still not received.
This is done only for those cases in which a timeout is not set.
Why:
For some reason, TLS1.3 behaves different than TLS1.2. For the first try of receiving a response, a GNUTLS_EAGAIN error is received, and currently only check again if there is a timeout set. Otherwise, connection is closed immediately.
As workaround, it will try now up to 10 times before closing the connection.
How:
In debian buster TLS1.3 is the default one. Set an ospd-openvas server with connection type TLS. Add the scanner to gvmd. Start a Task. It should end successfully. Without the patch, the connection is closed and the task is set as done with errors.
Checklist: