Fix printing valid xml attributes for an entity #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For exporting a XML report in gsad the `print_entity_to_string` function is used. While reading the report entity from the response all XML entities are unescaped. Therefore when using the `print_entity_to_string` it may create invalid XML attributes. Therefore ensure that all invalid characters for attributes (like &) are escaped before writing the entity to the GString.
mattmundell
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For exporting a XML report in gsad the
print_entity_to_stringfunctionis used. While reading the report entity from the response all XML
entities are unescaped. Therefore when using the
print_entity_to_stringit may create invalid XML attributes. Thereforeensure that all invalid characters for attributes (like &) are escaped
before writing the entity to the GString.