Ignore redundant tag cvss_base. #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a NASL script sets the tag "cvss_base" it will not be added to the tags for the respective NVT anymore. Thus it will also not be stored anymore in the redis database. This saves some space and, when tags are parsed, computing time. Not a fundamental improvement though. The OSP protocol already ignores this tag because the value can be computed from the vector anyway. So, this does not require other changes.
janowagner
added a commit
to janowagner/ospd-openvas
that referenced
this pull request
Sep 25, 2019
With greenbone/gvm-libs#267 these are not present anymore.
mattmundell
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a NASL script sets the tag "cvss_base" it will not be added
to the tags for the respective NVT anymore. Thus it will also not
be stored anymore in the redis database.
This saves some space and, when tags are parsed, computing time.
Not a fundamental improvement though.
The OSP protocol already ignores this tag because the value
can be computed from the vector anyway.
So, this does not require other changes.