Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow applying report configs to delta reports. #4082

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

a-h-abdelsalam
Copy link
Contributor

What

Allow applying report configs when exporting delta reports. The missing props were passed to the component DownloadReportDialog from DeltaReportDetails similar to how it is done from ReportDetails.

Why

Trying to export delta reports from GSA was throwing an error caused by report configs not being defined.

References

GEA-609

@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner June 27, 2024 14:14
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 90ead61.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link
Contributor

@daniele-mng daniele-mng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (5d09434) to head (90ead61).
Report is 10 commits behind head on main.

Files Patch % Lines
src/web/pages/reports/deltadetailspage.jsx 40.74% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4082      +/-   ##
==========================================
- Coverage   72.33%   72.32%   -0.02%     
==========================================
  Files        1068     1067       -1     
  Lines      122256   122252       -4     
  Branches     6059     6057       -2     
==========================================
- Hits        88438    88414      -24     
- Misses      33787    33807      +20     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-h-abdelsalam a-h-abdelsalam added the patch release Create a new patch release label Jun 28, 2024
@a-h-abdelsalam a-h-abdelsalam merged commit cd39ab5 into main Jun 28, 2024
12 of 13 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the fix-report-configs-for-delta-reports branch June 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Create a new patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants