Checking int fields for params and limiting retrieval amount #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -192,6 +193,8 @@ def get_timeline_query(user, uri, filename, machine_id, branch, metrics, phase, | |||
| if branch is None or branch.strip() == '': | |||
| branch = 'main' | |||
|
|
|||
| check_int_field_api(machine_id, 'machine_id', 1024) # can cause exception | |||
There was a problem hiding this comment.
style: The comment 'can cause exception' is redundant since the function name and its usage clearly indicate exception handling
|
Eco-CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Added integer field validation and retrieval limits to the API endpoints to enhance security and prevent excessive data retrieval.
check_int_field_api()inapi/api_helpers.pyto validate integer parameters with type, minimum and maximum value checksmachine_idparameter (max 1024) across API endpoints inapi/main.pylimitparameter with default=5 and max=50 for/v1/runsendpoint