Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding time to total-data.json and lap-data.json #60

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

nstruharova
Copy link
Contributor

Hi,
I added the time (or duration) parameter to the data files. I was not sure if this is a desirable feature for anyone else, however I needed this information for my research, and I thought it may be useful for other people too.

What prompted me to add the duration was the discrepancy I noticed between the duration calculated by EcoCI and the duration of the given step provided directly by the GitHub API. I am not sure if this is a big problem, but I wanted to leave this here as well in case it is an uncaught issue.

@ribalba ribalba requested a review from dan-mm February 22, 2024 15:03
@ArneTR
Copy link
Member

ArneTR commented Feb 23, 2024

Uhh, this looks nice, ty!

We are actually not using that data export too often, so I have to loop Dan in to give it a review. Looks legit for me though on first glimpse.

@dan-mm Please give it a look and merge if ok

@dan-mm
Copy link
Contributor

dan-mm commented Feb 23, 2024

Hi @nstruharova - it looks good to me! I'll merge it in after tests.

Also I think I can shed some light on the time discrepancy - the timer in Eco-CI only starts its internal timer after the initial setup, so that overhead is not attributed to the user's workflow. Additionally, the timer is reset at the end of the make_measurement step, so similarly some of Eco-CI's functionality is similarly not attributed to the user's workflow (though, as I'm taking another look at the code to verify this, the actual model run does happen within the timer, so that will be a part of it). In general, our design philosophy was that Eco-CI's functionality itself should not be a part of the energy estimation.

@dan-mm dan-mm merged commit 2aac9aa into green-coding-solutions:main Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants