-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize tweaks #53
Minimize tweaks #53
Conversation
Can you clarify why there is a hardcoded API_BASE variable in the code? The way I understand the add_var function it will update this variable. So will a user not always left with this API_BASE configured then? I thought. The variable should be able to be set by the surrounding github actions workflow file, right? So if you can set it there, why is there a hardcoding option that you temporarily patched in the first place? |
The API_BASE you're referring to is for the green metrics tool API, not the github API. So it shouldn't be configured by the github workflow (that only edits the github API base, which is no longer hardcoded). Maybe it could use a rename to GMT_API_BASE or something to clarify, now that we query multiple API endpoints. |
Cleaner looking output.
Now also checks comments for both the user (github bot) + Eco-CI as a string within the message