Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize tweaks #53

Merged
merged 12 commits into from
Dec 12, 2023
Merged

Minimize tweaks #53

merged 12 commits into from
Dec 12, 2023

Conversation

dan-mm
Copy link
Contributor

@dan-mm dan-mm commented Nov 30, 2023

Cleaner looking output.

Now also checks comments for both the user (github bot) + Eco-CI as a string within the message

Copy link

github-actions bot commented Nov 30, 2023

Old Energy Estimation

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 4.46714 24.7645 1.7689 23
Measurement #1 5.5375 12.3823 1.7689 9
Sleep #2 5.28 12.3823 1.7689 8

📈 Energy graph:

 
 2.00 ┼─────────────
       Watts over time

Copy link

github-actions bot commented Nov 30, 2023

Old Energy Estimation

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 4.87667 24.7645 1.7689 23
Measurement #1 6.0075 12.3823 1.7689 9
Sleep #2 5.575 12.3823 1.7689 9

📈 Energy graph:

 
 2.00 ┼─────────────
       Watts over time

scripts/setup.sh Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 1, 2023

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run 5.51 24.7645 1.7689 24
Measurement #1 6.015 12.3823 1.7689 9
Sleep #2 5.64125 12.3823 1.7689 9

📈 Energy graph:

 
 2.00 ┼─────────────
       Watts over time

@ArneTR
Copy link
Member

ArneTR commented Dec 2, 2023

Can you clarify why there is a hardcoded API_BASE variable in the code?

The way I understand the add_var function it will update this variable. So will a user not always left with this API_BASE configured then? I thought.

The variable should be able to be set by the surrounding github actions workflow file, right? So if you can set it there, why is there a hardcoding option that you temporarily patched in the first place?

@dan-mm
Copy link
Contributor Author

dan-mm commented Dec 4, 2023

The API_BASE you're referring to is for the green metrics tool API, not the github API. So it shouldn't be configured by the github workflow (that only edits the github API base, which is no longer hardcoded). Maybe it could use a rename to GMT_API_BASE or something to clarify, now that we query multiple API endpoints.

@dan-mm dan-mm merged commit 9550208 into main Dec 12, 2023
3 checks passed
@ArneTR ArneTR linked an issue Dec 18, 2023 that may be closed by this pull request
@ribalba ribalba deleted the minimize-tweaks branch December 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eco-CI Collapse function is broken
2 participants