Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#7): add output to gha for retrieving measured data for total and for every lap as json #15

Merged

Conversation

jreimone
Copy link
Contributor

@jreimone jreimone commented Apr 13, 2023

The measured data is made available as json string via step output as follows:

  • total by using the display-results task before: ${{ steps.XYZ.outputs.data-total-json }}
  • single step by using the get-measurement task before: ${{ steps.XYZ.outputs.data-lap-json }}

@jreimone jreimone marked this pull request as ready for review April 13, 2023 13:19
…ngle quotes because compared json contains double quotes itself
… that the lap measures are made available via output
…urrently the laps contain wrong label but the run succeeds
…olean string result to numeric and compare it
@jreimone
Copy link
Contributor Author

@rajbos, it took me a while but now we have an example workflow which demonstrates usage of the different outputs (either provided by get-measurement or display-results) and also asserts correct structure and labels. A successful run can be seen here.

In general, the output of the measurements had to be stored non-pretty-printed due to github action restrictions of multiline strings. Storing the json string in a 1-liner seemed way easier for me. This implies that the consumer of the output data needs to pretty print the json string.

Can you please re-review?

@jreimone jreimone requested a review from rajbos April 14, 2023 09:29
@jreimone jreimone changed the title feat(#7): add output to gha for retrieving total data as json feat(#7): add output to gha for retrieving measured data for total and for every lap as json Apr 14, 2023
@dan-mm dan-mm merged commit 81a5b40 into green-coding-solutions:main Apr 20, 2023
@jreimone jreimone deleted the introduce-measurement-output branch December 6, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants