lf_interop_throughput.py: Added testhouse changes and individual device configuration in the script. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-gavin
requested changes
Jul 23, 2025
py-scripts/lf_interop_throughput.py
Outdated
| if "devices" in interop_response.keys(): | ||
| interop_devices = interop_response['devices'] | ||
| # Extract usernames of devices that match the current eid | ||
| if(len([v['user-name'] for d in interop_devices for k, v in d.items() if v.get('resource-id') == b['eid']]) == 0): |
There was a problem hiding this comment.
Linting will catch this later, but best not to introduce from the start. Conditionals in Python should not have parentheses around sections that don't require it. Spacing will also be flagged too.
For conditionals, see example:
# Good
if my_var == 1:
pass
# Good, the `and` requires parentheses
if (my_var % 2 == 0 and my_var != 0) and my_var < 10:
pass
# Redundant parentheses
if (my_var == 1):
pass
# Redundant parentheses
if (my_var % 2 == 0 and my_var != 0):
pass There was a problem hiding this comment.
Got it,
Sure @a-gavin, will remove the parentheses in the coming commits.
py-scripts/lf_interop_throughput.py
Outdated
| for i in range(len(download_throughput)): | ||
| individual_df_data.extend([download_throughput[i], upload_throughput[i], drop_a_per[i], drop_b_per[i], int(signal_list[i]), link_speed_list[i], rx_rate_list[i]]) | ||
| individual_df_data.extend([download_throughput[i], upload_throughput[i], drop_a_per[i], drop_b_per[i], temp_avg_rtt[i][0], int(signal_list[i]), link_speed_list[i], rx_rate_list[i]]) |
There was a problem hiding this comment.
Fine as is, but any more complexity here probably warrants a dedicated test class to pass data around more succinctly.
…redundant URL formatting in Clear Wi-Fi Profiles API call Signed-off-by: litincandela <litin.ommi@candelatech.com>
Signed-off-by: litincandela <litin.ommi@candelatech.com>
…all CSV data.
VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75 \
--mgr_port 8080 \
--upstream_port eth1 \
--test_duration 1m \
--download 10000000 \
--traffic_type lf_udp
Signed-off-by: litincandela <litin.ommi@candelatech.com>
…and the report.
VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75\
--mgr_port 8080\
--upstream_port eth1\
--test_duration 1m\
--download 10000000\
--traffic_type lf_udp
- Took Average RTT data from Layer 3 Tab.
Signed-off-by: litincandela <litin.ommi@candelatech.com>
…o 1 second for WebGUI.
VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.74 \
--mgr_port 8080 \
--upstream_port eth0 \
--test_duration 30s \
--traffic_type lf_udp \
--ssid NETGEAR_2G_wpa2 \
--passwd Password@123 \
--security wpa2 \
--device_list 1.15,1.400 \
--download 10000000 \
--do_webgui
Signed-off-by: litincandela <litin.ommi@candelatech.com>
…teroperability test.
VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75\
--mgr_port 8080\
--upstream_port eth0\
--test_duration 1m\
--traffic_type lf_udp\
--ssid NETGEAR_2G_wpa2\
--passwd Password@123\
--security wpa2\
--do_interopability\
--download 10000000\
--interopability_config
- Added table for pass/fail to check whether device connected to the specific SSID.
- Skipping the devices failed to connect to the specific SSID to run the cx.
Signed-off-by: litincandela <litin.ommi@candelatech.com>
…report.
VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75\
--mgr_port 8080\
--upstream_port eth1\
--test_duration 1m\
--download 10000000\
--traffic_type lf_udp\
--dowebgui\
--get_live_view\
--total_floors
Signed-off-by: litincandela <litin.ommi@candelatech.com>
…as Mbps instead of bytes VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75 \ --mgr_port 8080 \ --upstream_port eth1 \ --test_duration 1m \ --download 10000000 \ --traffic_type lf_udp \ --tput_mbps Signed-off-by: litincandela <litin.ommi@candelatech.com>
… CSV and the report. VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75 \ --mgr_port 8080 \ --upstream_port eth0 \ --test_duration 1m \ --traffic_type lf_udp \ --ssid NETGEAR_2G_wpa2 \ --passwd Password@123 \ --security wpa2 \ --download 10000000 - Made some reporting changes in the report. Signed-off-by: litincandela <litin.ommi@candelatech.com>
VERIFIED CLI: python3 lf_interop_throughput.py --mgr 192.168.204.75\ --mgr_port 8080 \ --upstream_port eth0 \ --test_duration 1m \ --traffic_type lf_udp \ --ssid NETGEAR_2G_wpa2 \ --passwd Password@123 \ --security wpa2 \ --download 10000000 Signed-off-by: litincandela <litin.ommi@candelatech.com>
…al loops VERIFIED CLI: lf_interop_throughput.py python3 lf_interop_throughput.py --mgr 192.168.204.75\ --mgr_port 8080\ --upstream_port eth0\ --test_duration 1m\ --traffic_type lf_udp\ --ssid NETGEAR_2G_wpa2\ --passwd Password@123\ --security wpa2\ --download 10000000 Signed-off-by: litincandela <litin.ommi@candelatech.com>
litincandela
force-pushed
the
throughput_interoperability_testhouse_script
branch
from
d6398a7 to
0db0272
Compare
a-gavin
approved these changes
Aug 7, 2025
|
Thanks for reviewing @a-gavin . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.