Skip to content

Fix compile error #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pjc0247 wants to merge 1 commit into from
Closed

Fix compile error #397

pjc0247 wants to merge 1 commit into from

Conversation

@pjc0247
Copy link

@pjc0247 pjc0247 commented Feb 17, 2019

Unity.iOS is not exist by default.

@KojiNakamaru
Copy link
Member

KojiNakamaru commented Feb 18, 2019

Thank you for your contribution. Your fix is completely logical, but I intentionally don't utilize UNITY_IOS and/or UNITY_ANDROID, as Unity occasionally misses these for PostProcessBuild scripts.

cf. #342 (comment)
cf. https://answers.unity.com/questions/1512004/pbxproject-and-unity-ios-issue-in-postprocessbuild.html

I'll later add comments about this point in README.md.

KojiNakamaru added a commit that referenced this pull request Feb 18, 2019
@KojiNakamaru
updated README.md (cf. #397 (comment) ).
04e312c
@pjc0247
Copy link
Author

pjc0247 commented Feb 18, 2019

Thanks,

Unity, they always miss something

@pjc0247 pjc0247 closed this Feb 18, 2019
@KojiNakamaru KojiNakamaru mentioned this pull request Sep 2, 2019
Closed
@zlumer zlumer mentioned this pull request Jul 6, 2021
Closed
@KojiNakamaru KojiNakamaru mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pjc0247 @KojiNakamaru