-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for failing tests in master build #298
Conversation
@MaGering @Piranias was easier than thought --> just had to move The build passes for b3e85bb (apply black), where the tests of Unfortunately, I did a mistake: hotfixes are supposed to be merged into master branch, I selected dev and have already merged dev into the hotfix branch. So, as an exception we merge the hotfix to dev and it will find its way to |
…are into hotfix/package_data
Addresses #296
To test the hotfix, either #297 had to be solved first - or skip for failing tests had to be removed --> second option chosen --> todo
Changes proposed in this pull request:
test_examples.py
to examples folder to make tests work in CIThe following steps were realized, as well (required):
EXECUTE_TESTS_ON=master pytest
)Also the following steps were realized (if applies):
Please mark above checkboxes as following:
In case of an error due to linting, run
black . --exclude docs/
and push your changes.Note that in case you do not fix a whole issue you should start your PR with
Address #xyz
.For more information on how to contribute check the CONTRIBUTING.md.