Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt processing of evaluated period #265

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Adapt processing of evaluated period #265

merged 2 commits into from
Mar 24, 2021

Conversation

MaGering
Copy link
Collaborator

@MaGering MaGering commented Mar 23, 2021

With this PR it is possible to run simulations over a time period that is shorter than a day. This can be handy in order to study the calculations stored in the lp file.

The following steps were realized, as well (if applies):
❌ Use in-line comments to explain your code
❌ Write docstrings to your code
❌ For new functionalities: Explain in readthedocs
❌ Write test(s) for your new patch of code

  • Update the CHANGELOG.md (let's start this after the first release)
  • Apply black (black . --exclude docs/)
  • Check if full simulation tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

Copy link
Collaborator

@SabineHaas SabineHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I think we should use the checkboxes from now on - at least ticking the ones that can be applied to the PR. So before merging please fill in the changelog and run the test.

@MaGering MaGering merged commit f9724bb into dev Mar 24, 2021
@MaGering MaGering deleted the fix/evaluated_period branch March 24, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants