gateware: fix an order-of-operations bug with cdc.synchronize #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Closes #101 |
antoinevg
force-pushed
the
antoinevg/fix-cdc
branch
from
afe31a6 to
3907919
Compare
…utput signals would not be skipped if they were of Pin type
antoinevg
force-pushed
the
antoinevg/fix-cdc
branch
from
3907919 to
d46963a
Compare
|
Updated (with bonus unit test!) |
antoinevg
force-pushed
the
antoinevg/fix-cdc
branch
from
d46963a to
2d6df09
Compare
miek
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In db75437 a subtle bug was introduced into cdc.synchronize where nested elements of type
Pinwith directionalityoutputwould be recursed into and end up being driven byFFSynchronizerrather than being skipped.This would result in the signal being driven from multiple fragments: once from the top-level design and again by the undesired
FFSynchronizer.Prior to this change this was not an issue as the recursion operation only applied to elements of type
Record.Moving the directionality check to occur prior to the recursive operation resolves the issue.