This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
frontends:qt: ensure the packet list is displaying packets in original order #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of out-of-sequence
|
Closed in preparation for archiving the repository. We have replaced ViewSB with Packetry. You may be interested in particular in some Packetry features in development: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the analysis stack only sends complete packets to the frontend's visualisation queue when complete, this occasionally results in packets displayed out-of-order in the packet list.
This PR adds a check to safeguard the sequence of packets added to the QTreeWidget and in case these are out-of-sequence ensures the QTreeWidget gets sorted in sequence number.
expanding the transfer at packet 1:
This fixes #90