Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Add pre-commit autofix to PRs #8873

Merged
merged 10 commits into from
Oct 27, 2023

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Oct 26, 2023

Have pre-commit automatically update PRs based on linting violations
Let pre-commit fix pre-existing violations

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@cdkini cdkini self-assigned this Oct 26, 2023
@cdkini cdkini enabled auto-merge October 26, 2023 18:01
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit d7add15
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/653bd4f8d77a13000889437c

@github-actions github-actions bot added the core label Oct 26, 2023
@ghost
Copy link

ghost commented Oct 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 self-assigned this Oct 27, 2023
Comment on lines 8 to 9
tests/test_sets/fixed_distributional_test_dataset.json |
tests/test_sets/expected_cli_results_default.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first file in this list is intentionally invalid json but it's less obvious that the other 2 were meant to be.

auto-merge was automatically disabled October 27, 2023 15:09

Merge queue setting changed

@Kilo59 Kilo59 enabled auto-merge October 27, 2023 15:19
@Kilo59
Copy link
Contributor

Kilo59 commented Oct 27, 2023

@cla-bot check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why I had to make these changes 🤷

auto-merge was automatically disabled October 27, 2023 16:32

Merge queue setting changed

@anthonyburdi anthonyburdi merged commit e35029f into develop Oct 27, 2023
60 checks passed
@anthonyburdi anthonyburdi deleted the m/_/add_precommit_badge branch October 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants