-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom file name props for android #318
Conversation
Would be really nice to have this one! |
May I know the reason why you would want to give a name to that file? It's meant to be a temporary file that you later can reuse to send to a server / send to the user as a "share" action / ... |
For me the reason is the ability of downloading this file and it does not look good when the filename is something like "react-native......" in user's gallery. |
I didn't know this file would appear at all in user's phone, is it the case on Android? I thought the current folder used was invisible for the user. This is specifically documented in https://github.com/gre/react-native-view-shot#saving-to-a-file Overall i'm not sure if this is a good idea to put this in this library, it feels out of scope to me. but still open to discussion if there is no other workaround. |
In my case it would be nice to have the option to rename the file because I use this ViewShot capture sharing it on social networks like Instagram and WhatsApp and a name like ReactNative-snapshot is not so elegant, because before sharing an image the name of the file appears above the sharing options and in this case the image is temporary. |
Also renaming would allow be to save it straight to |
Thanks for the PR. |
No description provided.