Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidates the Android view cache after each shot. #3

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

skellock
Copy link
Contributor

Currently, you get 1 chance per-view on Android. It never expires the drawing cache after 1st shot.

This is a fix for that.

@gre
Copy link
Owner

gre commented Aug 25, 2016

looks like there is conflict with your other PR I merged in, could you fix it? thanks

@skellock
Copy link
Contributor Author

Indeed. Will rebase and untangle my mess.

@skellock skellock force-pushed the fix-android-cache-invalidation branch from b847fef to 2a42744 Compare August 25, 2016 12:48
@skellock
Copy link
Contributor Author

skellock commented Aug 25, 2016

@gre all set here....

I opted to stay with https://developer.android.com/reference/android/view/View.html#setDrawingCacheEnabled(boolean) as you did it like this instead of buildDrawingCache() & destroyDrawingCache().

Which is basically the same thing.

@gre gre merged commit ee38431 into gre:master Aug 25, 2016
@skellock skellock deleted the fix-android-cache-invalidation branch August 25, 2016 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants