Repository navigation
fix: address applicable security findings - #599
Open
grazzolini wants to merge 1 commit into
Open
grazzolini wants to merge 1 commit into
grazzolini wants to merge 1 commit into
Conversation
Update vulnerable dependency resolutions and parse tabs in linear time. Add regression coverage for traversal, symlinks, and packaging logs. Refs #584
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Refs #584. The assessed 58 records comprise 33 dependency findings with remediated version resolutions, 3 source-remediated parser findings, 18 source-reviewed exceptions, the GLib exception below, and 3 private draft evidence gaps that remain maintainer-owned. This PR does not close the issue or assert that every security record is resolved.
GLib exception
GLib 0.18.5 remains unpatched for RUSTSEC-2024-0429 (GHSA-wrw7-89jp-8q8g). It is excluded from this PR's remediation claims.
Source assessment on 2026-10-06 found no production call sites of the affected
VariantStrItermethods or its publicarray_iter_strfactory in the complete resolved Linux x86_64 default/custom-protocol graph: 613 production packages, 16,092 Rust/TOML source files, and zero missing package sources. Identified references were definitions, documentation, and tests. Private fields prevent direct construction outside GLib; source inspection identifiedarray_iter_stras the only caller of the crate-visible constructor. GenericVariantIterandVecFromVariantconversion use separate paths. Inspection of 17 generated Rust files found no affected references; this was not exhaustive macro-expansion tracing.Both
cargo check --release --lockedconfigurations passed on 2026-10-06 with Rust 1.98.0 in the pinnedghcr.io/grazzolini/tuneforge-ci@sha256:01e4207497cab9110b1857a32fcb38596c001e346296181c47405439f77c995cLinux/amd64 CI image, emulated on ARM64 Docker. The reviewer agreed that bounded non-applicability is supported for the assessed configurations. Compilation did not execute the affected iterator or the GUI; these checks do not establish runtime behavior, native Linux execution, or universal unreachability. The supplemental headless baseline/fix comparison was never executed because tool access was restricted.Assessment lockfile SHA-256:
4dc79b33f31754ed277b29a80bb5df88b32799e04360f785ddf6bcdfdbf56f8e. Reassess if dependency versions, resolved graph, features, or callers change.Testing
Recorded checks from 2026-10-06 are reused for the unchanged source tree committed as
5848351. Test runs used fresh isolated data and transport roots. Platform prerequisites were established for native checks; environment-specific path values are omitted below. Temporary full logs are no longer available.pnpm lint,pnpm typecheck, andpnpm testpassed; the latter included 553 native and 915 backend tests.pnpm contracts:generateproduced no committed contract drift.apps/backend:uv run --python 3.14 ruff check .,uv run --python 3.14 mypy app, anduv run --python 3.14 pytest -qpassed; 95 source files type-checked and 915 tests passed.uv run --python 3.14 pytest tests/test_tab_import_flow.py tests/test_projects.py tests/test_sync_manifest.py tests/test_sync_staging.py tests/test_sync_staging_api.py -qpassed 149 tests.node --test scripts/package-android.test.mjspassed 36 tests.apps/desktop/src-tauri:cargo test --locked sync_transport -- --test-threads=1passed 152 tests. An earlier parallel run had one timing-sensitive failure; the serial run and workspace native suite passed without source changes.cargo check --release --lockedandcargo check --release --locked --features custom-protocolfromapps/desktop/src-tauriunder the emulation boundary above.bash scripts/android-arm64-env.sh cargo check --manifest-path apps/desktop/src-tauri/Cargo.toml --target aarch64-linux-android --lockedpassed.rustup run stable cargo check --manifest-path apps/desktop/src-tauri/Cargo.toml --target aarch64-apple-ios-sim --lockedpassed with the existing stable target and selected Xcode developer directory.Checklist