Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render mini-roudabout just like a turning circle #4218

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Render mini-roudabout just like a turning circle #4218

merged 2 commits into from
Jan 23, 2021

Conversation

hiddewie
Copy link
Contributor

@hiddewie hiddewie commented Oct 11, 2020

Fixes #4167

Changes proposed in this pull request:

  • Make mini_roundabout be rendered exactly like a turning circle
  • Includes secondary and primary roads in the SQL query for turning circles.

The icon is still rendered. It can be removed, or changed to a single dot in the casing color of the road which contains the roundabout.

Test rendering with links to the example places: https://www.openstreetmap.org/#map=19/49.15015/7.77923&layers=N

Before/after renderings (zoom is shown in image):

image

image

image

image

image

image

@imagico
Copy link
Collaborator

imagico commented Oct 11, 2020

In principle a good idea. But you are not actually fixing #4167 this way because you keep rendering the mini roundabout symbol as a blocking symbol:

[feature = 'highway_mini_roundabout'][zoom >= 17]::highway {

I would suggest to follow the suggestion by @jeisenbe - continue rendering the center symbol, possibly in a less heavy variant (and possibly in casing color of the road) but without it blocking other symbols or labels.

@hiddewie
Copy link
Contributor Author

hiddewie commented Oct 11, 2020

@imagico Done. It is now a mini-dot in the middle of the roundabout. Not a blocking icon anymore.

That styling only applies to the mini_roundabout, not the turning-circles.

The color is matching the casing of the road that contains the roundabout.

Screenshots have been updated. Notice the zoom 19 screenshot that has a highway label which is not blocked by the roundabout.

@jeisenbe jeisenbe added the roads label Oct 29, 2020
@pnorman pnorman merged commit b01b2b1 into gravitystorm:master Jan 23, 2021
@polarbearing
Copy link
Contributor

Looks nice in the examples above, thanks.
Do we have any test rendering for lower roads, such as tertiary and residential, where mini roundabouts are more frequent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Road shield blocks highway=mini_roundabout
5 participants