Change societal amenities color

[Adamant36]

This PR changes the color of societal amenities to #fffced from #fbecd7. As it was, it didn't fit well with the new tones of other colors, because it was to bright or some such. Whatever the case, the new color looks way better. So, this PR should totally be approved. Closes #1991




P.S. I noticed there's an issue with the commits and files changed for some reason. I'll be fixing it shortly when I have the time.

[Tomasz-W]

For all interested in more test renderings at different zoom levels, you can find them here: #1991 (comment)

[kocio-pl]

Problems:

• gray items changeset is not needed here, it's just one-liner
• lch value in this line has changed, so please fix it

The result is much better:

https://www.openstreetmap.org/#map=15/52.2983/20.8425

Before

After

[kocio-pl]

I would however try with more yellow, because now it's hard to recognize it from bare ground, like here:

Before

After

[Adamant36]

@kocio-pl, thanks for the heads up. I noticed that was an issue. I keep having branch bleed over. I'll fix it when I get some time.

[Tomasz-W]

I would however try with more yellow

@Adamant36 Please make some test renderings with #FFFFE5

[Adamant36]

#FFFFE5 tests. I can do more if necessary.
next to farmland before

next to farmland after

z14 before

z14 after

z16 before

z16 after

z17 before

z17 after

[Adamant36]

@kocio-pl, I think I fixed the issues with the code. I couldn't get rid of the original bad commit. Plus, it says I added the code for bicycle repair stations and a few other things unrelated to the PR because of how I did it, but at least it doesn't have any conflicts anymore. Also, good suggestion about adding more yellow. It looks better.

[kocio-pl]

Great, looks even better! Could you test it also next to the bare ground (I'm especially interested in my example with disused school) and next to other yellow places like sand and beach?

[kocio-pl]

BTW: how would the previous societal color work now? Maybe it would be enough to have new farmland color?

[Tomasz-W]

@kocio-pl I don't understand. Which colour for which feature?

[kocio-pl]

The one we had till latest farmland change. @imagico swapped them and tuned it for new farmland, but I haven't tested if touching societal was really needed.

[kocio-pl]

Simple revert of this color would not work at all:

[kocio-pl]

However adding a bit of yellow (I have used 5% of old parking yellow - mix(#ffffe5, #f7efb7, 95%) ) works OK for me against both bare ground and farmland:

[kocio-pl]

My color is effectively #fffee3, so it looks very similar and #FFFFE5 is OK for me too, however label text should be probably darker, like 80% instead of 70%:

70%

80%

[kocio-pl]

#FFFFE5 with 90% darker text looks even better, I think:

[Tomasz-W]

I would stay with #FFFFE5 (it has better contrast with farmland areas) + 80% darker text (70% might be too light as shown in a test above, but 90% is too dark and it looks like a label of some another area)

[turnsole80]

I'm not too keen on this PR. I think the existing colour works just fine. A little contrast is not necessarily a bad thing IMO, especially when it comes to social amenities which ought to be reasonable easy to find on a map.

At the moment, we're running the risk of homogenising the map to the extent that objects are indistinguishable

[kocio-pl]

This contrast is too big for such popular landuse type like school or hospital (similar case to yellow parkings everywhere). It can work however for some less common areas - I guess culture and entertainment could be OK. Additional problem is that a lot of schools have pitch, which makes the contrast a bit painful.

This background is clear enough for me (that's why I was trying to tune original proposition with yellow and it has really helped).

[Adamant36]

@turnsole80, when I test rendering the yellow color it was actually easier to spot some social amenities at higher zoom levels then it currently is. Plus, they weren't hard to distinguish from similar colored things at all, at any zoom level. So, its not necessarily the case that they will be harder to spot or anything just because the color is changed or is similar to other colors. Which it really isn't.

[turnsole80]

Fair enough. I can see that there is a difference between social amenities and farms, so it should be okay from my point of view.

[kocio-pl]

@Adamant36 Could you update the code according to #3412 (comment)?

[Adamant36]

@kocio-pl, sure. I'll do it when I get a chance. Sorry for the delay.

[matthijsmelissen]

Nice improvement, thanks @Adamant36 !

[Adamant36]

@kocio-pl, I updated it. Hopefully its correct now.

[kocio-pl]

Much better now, thanks a lot!