Fix invisible barriers on tourism_boundary - step 1 #3037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves rendering the tourism-boundary layer under the barrier layer.
Rationale:
Barriers on tourism-boundaries (currently zoo, theme_park) are not visible. Here is a mixture of fenced and unfenced boundary - try to figure out. Hint: bride is unfenced, SW and NE corners are fenced.
There are two reasons:
#444
) line.This PR only fixes reason 1. The effects are currently marginal, however the fix is a prerequisite of working further on outlines while keeping barriers visible, see drafts in #2290, #2704, #3035. The actual colour of the zoo+theme_park outline can be addressed separately.
Details:
The
tourism-boundaries
layer was sitting betweennature-reserve-boundaries
andtrees
. It is now moved up in the project.mml to sit betweenlanduse-overlay
(current use military hatching) and thebarriers
class.Side effects:
As it is moved next to military, the effects are comparable to the military outline. It is now rendered under several unrelated features, the only notable is that the boundary renders under roads. I see this as beneficial, as it improves the visibility of gates; and if an ungated road runs over the boundary this is now clearer.
Before/after
As said, with the current brown boundary the visible effects are marginal, the darkness of the outer line is slightly strengthened (but that depends on the underlying landuse because of the opacity):
Before
After
Here is a proof with a bright colour on a wider, non-transparant line (the colour is not part of this PR) to make clear that the barrier was invisible before and becomes now visible:
Before, solid bright line over barrier:
After, same line under barrier:
Future Work
The PR enables to continue working on other outlines, where the presence of fences is well visible, example (not part of this PR):