Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible barriers on tourism_boundary - step 1 #3037

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

polarbearing
Copy link
Contributor

This PR moves rendering the tourism-boundary layer under the barrier layer.

Rationale:

Barriers on tourism-boundaries (currently zoo, theme_park) are not visible. Here is a mixture of fenced and unfenced boundary - try to figure out. Hint: bride is unfenced, SW and NE corners are fenced.
z19_zoo_fenced-unfenced-mix

There are two reasons:

  1. tourism-boundary is rendered in a higher layer than barriers
  2. the current outer line of the tourism outline (a/line) is relatively dark brown. As it uses opacity=0.5 the barrier shines weakly through, but this is barely noticeable since barrier uses a very thin (width=0.4) grey (#444) line.

This PR only fixes reason 1. The effects are currently marginal, however the fix is a prerequisite of working further on outlines while keeping barriers visible, see drafts in #2290, #2704, #3035. The actual colour of the zoo+theme_park outline can be addressed separately.

Details:

The tourism-boundaries layer was sitting between nature-reserve-boundaries and trees. It is now moved up in the project.mml to sit between landuse-overlay (current use military hatching) and the barriers class.

Side effects:

As it is moved next to military, the effects are comparable to the military outline. It is now rendered under several unrelated features, the only notable is that the boundary renders under roads. I see this as beneficial, as it improves the visibility of gates; and if an ungated road runs over the boundary this is now clearer.

Before/after

As said, with the current brown boundary the visible effects are marginal, the darkness of the outer line is slightly strengthened (but that depends on the underlying landuse because of the opacity):
Before
prz19_current_fenced
After
prz19_after_fenced

Here is a proof with a bright colour on a wider, non-transparant line (the colour is not part of this PR) to make clear that the barrier was invisible before and becomes now visible:
Before, solid bright line over barrier:
z19_proof_current_barrier_under_boundary
After, same line under barrier:
z19_proof_barrier_over_tourism_boundary

Future Work

The PR enables to continue working on other outlines, where the presence of fences is well visible, example (not part of this PR):
z19_transport-light_barrier_over_outline

Copy link
Collaborator

@kocio-pl kocio-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sane step for these outlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants