Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yellow background for community_centre and social_facility #2981

Merged
merged 1 commit into from
Dec 17, 2017

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Dec 12, 2017

Related to #2087.

I think it's safe to add community_centre (#506) and social_facility (#1295) as societal amenities - with a light yellow background.

I would also like to add arts_centre, since this is sometimes similar to community_centre, but I'm not sure if this would be accepted - what do you think about it? We don't have a clean, generic solution for lot of "campuses" and social services, so I prefer to make smaller steps where this seems quite consistent rather than try to solve as much as it's possible.

amenity=social_facility
Before
i5qq_aje

After
glqi5ovz

amenity=community_centre
Before
phkevc4e

After
hydv oni

@polarbearing
Copy link
Contributor

Looks fine for me. Do I understand correctly that we only add the fill, and leave the label as it is?
That means not scaling with area size. Which is probably fine, since these campuses tend to be compact in comparison to large schools/universities.

And yes let's continue in small steps and not throw in all ideas at once. I have more ideas, also.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Dec 12, 2017

Yes, we have no idea what to do with scaling when we show the icon. If we knew, we would have school icons set already (see #2361 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants