Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified rendering of leisure=fitness_station and leisure=fitness_centre #2891

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

kocio-pl
Copy link
Collaborator

Resolves #1870
Resolves #2375

  1. Unifies both fitness amenities, because the main difference is if they are inside building or in the outdoor, which is already visible from the context.
  2. Uses general activity icon from shop=sports, but with a leisure green color and mirrored to make it even more distinctive.
  3. Also makes fitness station close to the other small leisure amenities (like playground).

Example z19 rendering

fitness centre
Before
reiw6yed

After
zeiwj02u

fitness station
Before
0nhpq7p3

After
4a24_vkc

@boothym
Copy link
Contributor

boothym commented Oct 22, 2017

Not sure if the fitness centre colour needs to be changed, it should remain the same as sports centre.

Will this render fitness station nodes as well?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 23, 2017

Not sure if the fitness centre colour needs to be changed, it should remain the same as sports centre.

The only good thing about this style was it was rendered at all. If the name doesn't contain "fitness" or you don't know the script or language, it's not clear if this is fitness centre, school or anything like that.

Will this render fitness station nodes as well?

Yes. That's why we need the icon.

@andrewharvey
Copy link

Looks good to me.

@kocio-pl kocio-pl merged commit b55d202 into gravitystorm:master Nov 12, 2017
@kocio-pl kocio-pl deleted the fitness branch November 12, 2017 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add leisure=fitness_centre icon/text Render leisure=fitness_station
4 participants