-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for tourism=artwork #855
Comments
If the individual artwork was noteworthy it would be an attraction that would be rendered. I would close |
Not sure. I think sculptures are always landmarks, even when they are not attractions. |
|
We obviously could add icons for every possible tag but we don't we only add notable/worthy ones. I think currently there is a pause on adding new icons hence another reason for a close. |
Yes, but I think we can leave the issues open for the next phase. |
Names of artworks would be useful to show as points; this is shown on the cycle map, and I definitely miss it on the regular map. |
As of writing this comment, the lack of |
2014-11-26 18:44 GMT+01:00 Minh Nguyễn notifications@github.com:
yes. this was re-added shortly after I had removed the duplication node cheers, |
I guess the icon is worth showing even without the name - at least for such artwork types as sculpture, statue or a stone. In the parks for example they are the common landmarks, together with some buildings and fountains (that's why I have created this ticket: #705). |
Currently 37500 occurrences, most of them nodes, about 2500 on ways (e.g., on walls). |
I guess this is so broad category, that I would rather wait for database reload, so we could know exact type and join them with corresponding memorial types. We could render them that way for example:
It's hard for me to imagine the general "artwork" icon, but I can test some ideas. If this is accepted, we wouldn't have to wait for anything more. |
I detailed some problems with tourism=attraction here: http://wiki.openstreetmap.org/wiki/Talk:Tag:tourism%3Dattraction |
What about something abstract like this? |
@kocio-pl yes, any icon will work. Even coloured dot (similar to shop=yes), tourism=artwork features are important landmarks at z17+ levels (or even 16+). I think they should be rendered equally with historic=memorial; but some metropolitan areas have too many sculptures IRL and rendering of tourism=artwork isn't important for them. |
I really like the general idea. But with the triangle at the bottom, it somehow reminds me of a vintage camera. Could the triangle be at the top again? |
Would a palette (like https://cdn0.iconfinder.com/data/icons/business-vector-tab-bar-icons/48/painter_palette-512.png ) be a good idea for all artworks? Or would we get complaints that a statue is not a painting...? |
IMO there is no sure solution, since it could also mean shop=art (in violet), art gallery or arts centre. I like abstract blocks as the artwork can be very different - like sculpture, graffiti, stone, painting, logo, installation... However I don't exclude palette if we agree about other possible uses of this symbol. |
I vote for no4. There no good icon for sculptures in any case. Having icon for "paintings" is possible, but: http://taginfo.openstreetmap.org/keys/artwork_type#values: Please make a good enough icon for these 2 first rather how to include special case rendering of 1.25% :) |
So maybe we could design general statue icon, to match just the majority of cases (since 15% is relatively unimportant)? |
I don't know, but if you provide SVG link, I can test it visually at least. |
And maybe also try this |
Unfortunately, you are right about the second version. In places that are "cramped" with artwork, it's way to heavy. The question is if this makes sense at all. Don't get me wrong - I absolutely agree with tourism=artwork being rendered. But maybe only at the lowest zoom level. I quite like the icon when it's a single instance, though. |
The spiral shaped icon works fine. The fact that it's lighter is a good thing. Is it really too abstract? Some other opinions would be great. |
What about statue-like design (technically it's toilet+monument =} )? I like it. It's light, similar to info point lightness (small "i" letter), but it still resembles popular artwork type and works reasonably even in the worst case (crowded z17): If we have more artwork-crowded places we could show only named artworks from z17 and the rest (without name) from z18. |
sent from a phone
we could watch out for the combination with attraction. Rendering artwork will make more sense when hstore is active and we can differentiate by type |
sent from a phone
it's a bit too big, with 1 wind less it would be better I think. Generally it could work, but still e.g. in the case of a statue there is some discrepancy in the overall shape. I could imagine also a tiny square (which doesn't convey any shape because more evidently represents a point) and a label |
Brilliant idea to combine "toilet" and "monument". :-) However, I see two problems: one is that it resembles the memorial icon. Another is that this proposal focuses only on statues. It would not be a good representation of graffiti, paintings, etc. Your first approach (triangle, square, and circle) was very abstract. And I think we should pursue this idea further. |
For me it looks like the Oscar statue and is substantially different than memorial icon (compare both types in Lazienki Park for example). I also think focus on ~85% of objects is a fair trade for now. However when hstore will be available I think we could use spiral for all the other artwork types (~15%). |
I like that statue icon! It's very understandable and not intrusive. Great way to recycle existing elements and still be different enough to avoid confusion.
So, ~70% of artwork_types are not statues. Sculptures are probably mostly abstract, and could use a more abstract icon, like the spiral. What about making the spiral a bit smaller like @dieterdreist said? maybe 1,5 turns would already be enough, and could allow for thickening the line a bit? Another idea would be to use the small pedestal from the "oscar statue" and put a small diamond shape and a circle on top of it. So its similar in size and shape (not so dense), but more abstract. |
I tried both your suggestions. Unfortunately, 1,5 turns don't work for the spiral. It's hardly a spiral any more. But 2,3 turns are fine. See here: http://roeskamp.de/osm/artwork_01-02.svg I also liked your other idea with the diamond. I had started to think into the same direction already. :-) Is this like what you had in mind? http://roeskamp.de/osm/artwork_03.svg |
@kocio-pl: Great idea to distinguish between different kinds of artwork. As I said, I like your statue icon for statues. If we could have something more abstract for everything else, that would be perfect. |
We should really be careful not to overcrowd the map. At the given zoomlevels, I think the art works are not relevant enough compared to the other features, I'd recommend rendering from z18 on. |
I have also made some variations
|
the svg have been rejected but are available |
I just put icons into code branch, probably also "gists" (loose code collections) are possible here? I would try rendering with 5. BTW: simple rectangular maze could be another idea - it would be better pixel aligned than spiral, so I guess also more crisp. |
2016-07-23 17:09 GMT+02:00 kocio-pl notifications@github.com:
+1, I would try 5 and 7, unfortunately don't have a working rendering stack |
I would like to see a rendering with 7. 1-5 are not recognizable enough to me (if anything, they'd represent a fire extinguisher to me). |
After all those suggestions, I think I prefer @daganzdaanda's idea with the pedestal, diamond, and circle. It's light enough on the map, concrete enough to symbolize a statue, and abstract enough to represent sculptures and other artworks. It seems to meet all our requirements so far. |
sent from a phone
IMHO it's clearly a statue an not suitable for paintings, graffiti, landart, etc. |
I also like the simple and abstract diamond icon. It is as universal as the spiral, but I agree with @math1985 that the spiral may look like a fire equipment (I didn't make such connection myself, but in fact there's similar icon in JOSM) and diamond look more like a "gem" on game maps to me - which I feel is consistent with the idea of the "artwork" on the real map. So for now I would like to use diamond as a general artwork icon from z18 (to not overcrowd z17, which seems like a land between mapping and micromapping world). After we have hstore available, I would also add statue icon only for statues (~30% of artworks) and show "special" artworks earlier, like z16 or z17 (when we have "tourist_attraction=yes" established as an alternative form for "tourism=attraction"). What do you think about that? |
The tag tourism=artwork should be rendered with icon.
See also https://trac.openstreetmap.org/ticket/4529.
The text was updated successfully, but these errors were encountered: