Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniature_golf has same colour as camp_site #4919

Open
BertMule opened this issue Dec 28, 2023 · 3 comments
Open

miniature_golf has same colour as camp_site #4919

BertMule opened this issue Dec 28, 2023 · 3 comments

Comments

@BertMule
Copy link

A miniature_golf has the same colour as a camp_site.
With the first as part of the latter, there is no contrast.
Which beats the intend of separately modelling them.

As shown here,

@BertMule BertMule changed the title miniature_golf has ame colour as camp_site miniature_golf has same colour as camp_site Dec 28, 2023
@imagico
Copy link
Collaborator

imagico commented Dec 29, 2023

Yes, this goes back to the decision from #4381, which was prepared in #4212 - where the choice of color was discussed in more depth.

Currently we use the same color for:

  • tourism=camp_site
  • tourism=caravan_site
  • tourism=picnic_site
  • leisure=golf_course
  • leisure=miniature_golf

That is not ideal - but the problem is mitigated by the fact that all of these are rendered with a point symbol as well - resolving the ambivalence in color.

As discussed in #4212 already, solving this overloading of color use is difficult given the large number of green colors we already use. If anyone would like to look into this, disentangling the much broader overloading of the very light blue-green color (labeled @leisure) would most certainly need to be the first step - see #4212 (comment)

@dch0ph
Copy link
Contributor

dch0ph commented Dec 30, 2023

Yes, a new green is unlikely to work.

There similarly wasn't much enthusiasm for highlighting borders of leisure=golf_course (which would be an alternative): #4870
Not least because there would normally be some kind of barrier (or natural feature) demarcating a golf course.

Wouldn't most leisure=miniature_golf similarly have a barrier? In this case, simply more detailed mapping would make the issue go away.

An alternative would be to render leisure=miniature_golf as leisure=playground on the basis that crazy golf arguably has more similarities to a constructed playground than a "semi-natural" golf course. leisure=playground has a thin border would help with demarcation if a barrier is not mapped.

@BertMule
Copy link
Author

I would be in favour of at least some border.

A distinctive colour would be better.
But I understand the problem there.

Comparable with outdoor seatings #4792.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants